skip to main content
10.1145/3183519.3183542acmconferencesArticle/Chapter ViewAbstractPublication PagesicseConference Proceedingsconference-collections
research-article

Studying pull request merges: a case study of shopify's active merchant

Published:27 May 2018Publication History

ABSTRACT

Pull-based development has become a popular choice for developing distributed projects, such as those hosted on GitHub. In this model, contributions are pulled from forked repositories, modified, and then later merged back into the main repository. In this work, we report on two empirical studies that investigate pull request (PR) merges of Active Merchant, a commercial project developed by Shopify Inc. In the first study, we apply data mining techniques on the project's GitHub repository to explore the nature of merges, and we conduct a manual inspection of pull requests; we also investigate what factors contribute to PR merge time and outcome. In the second study, we perform a qualitative analysis of the results of a survey of developers who contributed to Active Merchant. The study addresses the topic of PR review quality and developers' perception of it. The results provide insights into how these developers perform pull request merges, and what factors they find contribute to how they review and merge pull requests.

References

  1. Alberto Bacchelli and Christian Bird. 2013. Expectations, Outcomes, and Challenges of Modern Code Review. In Proc. of the Int. Conf. on Soft. Eng. 712--721. Google ScholarGoogle ScholarDigital LibraryDigital Library
  2. Olga Baysal, Oleksii Kononenko, Reid Holmes, and Michael W Godfrey. 2012. The secret life of patches: A firefox case study. In Proc. of the Working Conf. on Reverse Eng. 447--455. Google ScholarGoogle ScholarDigital LibraryDigital Library
  3. Olga Baysal, Oleksii Kononenko, Reid Holmes, and Michael W. Godfrey. 2016. Investigating technical and non-technical factors influencing modern code review. Empirical Soft. Eng. 21, 3 (2016), 932--959. Google ScholarGoogle ScholarDigital LibraryDigital Library
  4. Christian Bird, Alex Gourley, Prem Devanbu, Anand Swaminathan, and Greta Hsu. 2007. Open borders? immigration in open source projects. In Proc. of the Int. Workshop on Mining Soft. Repositories. Google ScholarGoogle ScholarDigital LibraryDigital Library
  5. Marcelo Cataldo, Audris Mockus, Jeffrey A Roberts, and James D Herbsleb. 2009. Software dependencies, work dependencies, and their impact on failures. IEEE Transactions on Soft. Eng. 35, 6 (2009), 864--878. Google ScholarGoogle ScholarDigital LibraryDigital Library
  6. Rune Haubo B Christensen and Merete K Hansen. 2011. binomTools: Performing diagnostics on binomial regression models. R package version 1.0-1.Google ScholarGoogle Scholar
  7. J. Cohen. 2003. Applied Multiple Regression - Correlation Analysis for the Behavioral Sciences.Google ScholarGoogle Scholar
  8. J. Fox. 2008. Applied Regression Analysis and Generalized Linear Models.Google ScholarGoogle Scholar
  9. John Fox and Sanford Weisberg. 2011. An R Companion to Applied Regression (second ed.).Google ScholarGoogle Scholar
  10. Deen Freelon. {n. d.}. ReCal2: Reliability for 2 Coders. http://dfreelon.org/utils/recalfront/recal2/. ({n. d.}).Google ScholarGoogle Scholar
  11. Georgios Gousios, Martin Pinzger, and Arie van Deursen. 2014. An exploratory study of the pull-based software development model. In Proc. of the Int. Conf. on Soft. Eng. 345--355. Google ScholarGoogle ScholarDigital LibraryDigital Library
  12. Georgios Gousios, Margaret-Anne Storey, and Alberto Bacchelli. 2016. Work Practices and Challenges in Pull-based Development: The Contributor's Perspective. In Proc. of the Int. Conf. on Soft. Eng. 285--296. Google ScholarGoogle ScholarDigital LibraryDigital Library
  13. Georgios Gousios, Andy Zaidman, Margaret-Anne Storey, and Arie Van Deursen. 2015. Work practices and challenges in pull-based development: the integrator's perspective. In Proc. of the Int. Conf. on Soft. Eng. 358--368. Google ScholarGoogle ScholarDigital LibraryDigital Library
  14. R.M. Groves, F.J. Fowler, M.P. Couper, J.M. Lepkowski, E. Singer, and R. Tourangeau. 2009. Survey Methodology (2 ed.).Google ScholarGoogle Scholar
  15. Trevor Hastie, Robert Tibshirani, and Jerome Friedman. 2009. The elements of statistical learning: data mining, inference and prediction (2 ed.).Google ScholarGoogle Scholar
  16. Les Hatton. 2008. Testing the Value of Checklists in Code Inspections. IEEE Software 25, 4 (2008), 82--88. Google ScholarGoogle ScholarDigital LibraryDigital Library
  17. Yujuan Jiang, Bram Adams, and Daniel M. German. 2013. Will My Patch Make It? And How Fast?: Case Study on the Linux Kernel. In Proc. of Working Conf. on Mining Soft. Repos. 101--110. Google ScholarGoogle ScholarDigital LibraryDigital Library
  18. Eirini Kalliamvakou, Georgios Gousios, Kelly Blincoe, Leif Singer, Daniel M German, and Daniela Damian. 2014. The promises and perils of mining GitHub. In Proc. of the Working Conf. on mining Soft. Repositories. ACM, 92--101. Google ScholarGoogle ScholarDigital LibraryDigital Library
  19. Chris F. Kemerer and Mark C. Paulk. 2009. The Impact of Design and Code Reviews on Software Quality: An Empirical Study Based on PSP Data. IEEE Trans. Soft. Eng. 35, 4 (July 2009), 534--550. Google ScholarGoogle ScholarDigital LibraryDigital Library
  20. Oleksii Kononenko, Olga Baysal, and Michael W Godfrey. 2016. Code review quality: how developers see it. In Proc. of the Int. Conf. on Soft. Eng. 1028--1038. Google ScholarGoogle ScholarDigital LibraryDigital Library
  21. Oleksii Kononenko, Olga Baysal, Latifa Guerrouj, Yaxin Cao, and Michael W. Godfrey. 2015. Investigating Code Review Quality: Do People and Participation Matter?. In Proc. of the Int. Conf. on Soft. Maintenance and Evolution. 111--120. Google ScholarGoogle ScholarDigital LibraryDigital Library
  22. William H. Kruskal and W. Allen Wallis. 1952. Use of Ranks in One-Criterion Variance Analysis. Journ. of the American Statistical Ass. 47, 260 (1952), 583--621.Google ScholarGoogle ScholarCross RefCross Ref
  23. E.L. Lehmann and H.J.M. D'Abrera. 2006. Nonparametrics: statistical methods based on ranks.Google ScholarGoogle Scholar
  24. Jennifer Marlow, Laura Dabbish, and Jim Herbsleb. 2013. Impression Formation in Online Peer Production: Activity Traces and Personal Profiles in Github. In Proc. of the Conf. on Computer Supported Cooperative Work. 117--128. Google ScholarGoogle ScholarDigital LibraryDigital Library
  25. Shane McIntosh, Yasutaka Kamei, Bram Adams, and Ahmed E. Hassan. 2014. The Impact of Code Review Coverage and Code Review Participation on Software Quality: A Case Study of the Qt, VTK, and ITK Projects. In Proc. of the Working Conf. on Mining Soft. Repos. 192--201. Google ScholarGoogle ScholarDigital LibraryDigital Library
  26. Shane Mcintosh, Yasutaka Kamei, Bram Adams, and Ahmed E. Hassan. 2016. An Empirical Study of the Impact of Modern Code Review Practices on Software Quality. Empirical Soft. Eng. 21, 5 (Oct. 2016), 2146--2189. Google ScholarGoogle ScholarDigital LibraryDigital Library
  27. M.B. Miles and A.M. Huberman. 1994. Qualitative Data Analysis: An Expanded Sourcebook.Google ScholarGoogle Scholar
  28. Audris Mockus. 2010. Organizational volatility and its effects on software defects. In Proc. of the Int. Symposium on Foundations of Soft. Eng. 117--126. Google ScholarGoogle ScholarDigital LibraryDigital Library
  29. Audris Mockus, Roy T Fielding, and James D Herbsleb. 2002. Two case studies of open source software development: Apache and Mozilla. ACM Transactions on Soft. Eng. and Methodology 11, 3 (2002), 309--346. Google ScholarGoogle ScholarDigital LibraryDigital Library
  30. Peter C. Rigbyand Christian Bird. 2013. Convergent Contemporary Software Peer Review Practices. In Proc. of the Joint Meeting on Foundations of Soft. Eng. 202--212. Google ScholarGoogle ScholarDigital LibraryDigital Library
  31. Peter C Rigby and Daniel M German. 2006. A preliminary examination of code review processes in open source projects. Technical Report. DCS-305-IR, University of Victoria.Google ScholarGoogle Scholar
  32. Peter C. Rigby and Margaret-Anne Storey. 2011. Understanding Broadcast Based Peer Review on Open Source Software Projects. In Proc. of the Int. Conf. on Soft. Eng. 541--550. Google ScholarGoogle ScholarDigital LibraryDigital Library
  33. Shopify. 2017. Active Merchant. https://github.com/activemerchant/active_merchant/. (2017).Google ScholarGoogle Scholar
  34. Tue Tjur. 2009. Coefficients of determination in logistic regression models - A new proposal: The coefficient of discrimination. The American Statistician 63, 4 (2009), 366--372.Google ScholarGoogle ScholarCross RefCross Ref
  35. Jason Tsay, Laura Dabbish, and James Herbsleb. 2014. Influence of Social and Technical Factors for Evaluating Contribution in GitHub. In Proc. of the 36th Int. Conf. on Soft. Eng. 356--366. Google ScholarGoogle ScholarDigital LibraryDigital Library
  36. Peter Weissgerber, Daniel Neu, and Stephan Diehl. 2008. Small patches get in!. In Proc. of the Working Conf. on Mining Soft. Repos. 67--76. Google ScholarGoogle ScholarDigital LibraryDigital Library

Index Terms

  1. Studying pull request merges: a case study of shopify's active merchant

      Recommendations

      Comments

      Login options

      Check if you have access through your login credentials or your institution to get full access on this article.

      Sign in
      • Published in

        cover image ACM Conferences
        ICSE-SEIP '18: Proceedings of the 40th International Conference on Software Engineering: Software Engineering in Practice
        May 2018
        336 pages
        ISBN:9781450356596
        DOI:10.1145/3183519

        Copyright © 2018 ACM

        Permission to make digital or hard copies of all or part of this work for personal or classroom use is granted without fee provided that copies are not made or distributed for profit or commercial advantage and that copies bear this notice and the full citation on the first page. Copyrights for components of this work owned by others than ACM must be honored. Abstracting with credit is permitted. To copy otherwise, or republish, to post on servers or to redistribute to lists, requires prior specific permission and/or a fee. Request permissions from [email protected]

        Publisher

        Association for Computing Machinery

        New York, NY, United States

        Publication History

        • Published: 27 May 2018

        Permissions

        Request permissions about this article.

        Request Permissions

        Check for updates

        Qualifiers

        • research-article

        Upcoming Conference

        ICSE 2025

      PDF Format

      View or Download as a PDF file.

      PDF

      eReader

      View online with eReader.

      eReader